Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in websockets, doesn't seem to affect anything #617

Closed
hmpf opened this issue Apr 18, 2023 · 0 comments · Fixed by #618
Closed

Bug in websockets, doesn't seem to affect anything #617

hmpf opened this issue Apr 18, 2023 · 0 comments · Fixed by #618
Labels
bug Something is not working as expected dependencies Run `tox -r` before testing locally, dependencies have changed

Comments

@hmpf
Copy link
Contributor

hmpf commented Apr 18, 2023

Channels-redis: "Update to v4 results in "RuntimeError: Event loop is closed""

django/channels_redis#332

2023-04-18 09:39:17,297 asyncio      default_exception_handler ERROR    Task exception was never retrieved
future: <Task finished name='Task-5' coro=<Connection.disconnect() done, defined at /usr/local/lib/python3.10/site-packages/redis/asyncio/connection.py:723> exception=RuntimeError('Event loop is closed')>
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/redis/asyncio/connection.py", line 732, in disconnect
    self._writer.close()  # type: ignore[union-attr]
  File "/usr/local/lib/python3.10/asyncio/streams.py", line 337, in close
    return self._transport.close()
  File "/usr/local/lib/python3.10/asyncio/selector_events.py", line 706, in close
    self._loop.call_soon(self._call_connection_lost, None)
  File "/usr/local/lib/python3.10/asyncio/base_events.py", line 753, in call_soon
    self._check_closed()
  File "/usr/local/lib/python3.10/asyncio/base_events.py", line 515, in _check_closed
    raise RuntimeError('Event loop is closed')
RuntimeError: Event loop is closed

We're probably hit by this due to src/argus/ws/consumers.py. There's a new channels-redis out, 4.1.0, which according to its changelog fixes this. It might also be necessary to roll redis itself back a little.

@hmpf hmpf added bug Something is not working as expected dependencies Run `tox -r` before testing locally, dependencies have changed labels Apr 18, 2023
@hmpf hmpf closed this as completed in #618 Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working as expected dependencies Run `tox -r` before testing locally, dependencies have changed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant