Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only write heading in blue if stdout is terminal #97

Merged
merged 3 commits into from
Oct 25, 2018

Conversation

lassik
Copy link
Contributor

@lassik lassik commented Oct 11, 2018

Adds a new method writeOutHeading to the BaseCommand class.

Fixes some of the failing unit tests in #95.

@lassik
Copy link
Contributor Author

lassik commented Oct 11, 2018

Verified that this works locally on Mac. By comparing the output of unibeautify support -l (shows colors) and unibeautify support -l | cat (doesn't show color) in a terminal window.

@lassik
Copy link
Contributor Author

lassik commented Oct 12, 2018

Travis failed on Linux due to some Node/NPM update taking ages. Please retry it.

@lassik
Copy link
Contributor Author

lassik commented Oct 23, 2018

@stevenzeck @Glavin001 Can you restart the Travis build for this PR?

@stevenzeck
Copy link
Contributor

@lassik I removed the Travis CI and Unibeautify - Branch status check requirements, it doesn't work unless you have your fork setup to run Travis (I think).

@stevenzeck stevenzeck merged commit 2682df0 into Unibeautify:master Oct 25, 2018
@lassik lassik deleted the isatty branch October 26, 2018 12:07
@lassik
Copy link
Contributor Author

lassik commented Oct 26, 2018

Thanks for merging. In the future, we ought to rebase each PR to the latest master before merging it. The Git history (git log --graph) gets quite convoluted otherwise :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants