-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Branch filtering #2
Comments
@stevenzeck Great observation! Do you think disabling branches with glob patterns would be a good solution? For example, exclude Also I think this should be moved to https://github.com/Unibeautify/unibeautify-ci-issues |
From @lassik on October 17, 2018 13:8 Unibeautify CI is the cloud-based job that prints style errors on Travis, right? It's really cool! Would it work to only enable it for PRs? If our workflow is that humans only commit via PR, and Renovate only commits changes to |
No, it is completely separate solution from Travis CI or other CIs. Unibeautify CI creates a branch with fixes, if applicable, and generates a report to show in GitHub Checks tab: https://blog.github.com/2018-05-07-introducing-checks-api/ Check out https://github.com/apps/unibeautify-ci 🎉 !
I wonder if I can detect which PRs are opened by humans or not 🤔 . |
From @stevenzeck on October 17, 2018 17:45 https://docs.travis-ci.com/user/customizing-the-build/#safelisting-or-blocklisting-branches
|
Good point, @stevenzeck . Learn from the best. Travis CI, tried and true. |
From @stevenzeck on October 12, 2018 15:40
Unibeautify CI is great, however if left unchecked it can cause a TON of backlogs in Travis. I forget which repo it was, but Unibeautify was not correct on master. Whenever Renovate created a new branch for a dependency update, Unibeautify CI also created a branch to fix the branch that Renovate created. Scenario example:
unibeautify/master
branch to fix itrenovate/typescript3.x
. Travis CI build starts for this branchrenovate/typescript3.x
also fails UB CI, so UB CI creates a branch to fix it:unibeautify/renovate/typescript3.x
. Another Travis CI build starts for this branchunibeautify/renovate/typescript3.x
torenovate/typescript3.x
. Travis CI build startsrenovate/typescript3.x
That's 4 Travis CI builds when it only needs 1.
Copied from original issue: Unibeautify/unibeautify#205
The text was updated successfully, but these errors were encountered: