Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support node_exporter >=0.15.0 #18

Closed
tereschenkov opened this issue Oct 20, 2017 · 5 comments
Closed

Support node_exporter >=0.15.0 #18

tereschenkov opened this issue Oct 20, 2017 · 5 comments

Comments

@tereschenkov
Copy link

Role is not working with node_exporter >= 0.15.0

Due to prometheus/node_exporter#640 and prometheus/node_exporter#639 changes, templates that generate systemd/init/etc configuration files need to be updated to use new flags structure
@Sispheor
Copy link
Contributor

I confirm, it's one --collector.<name> per collector.
Do you accept PR?
Do you want to keep your role working with version < 15?

@UnderGreen
Copy link
Owner

I accept PR's.
But.. what is so bad, I don't have free time to create PR's.

@Sispheor
Copy link
Contributor

I'm on it

@Sispheor Sispheor mentioned this issue Nov 15, 2017
Merged
@tomasfse
Copy link

Fantastic!! @UnderGreen please, could you do a release, here or at ansible-galaxy?

Thanks!

@Sispheor
Copy link
Contributor

This is done. Can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tereschenkov @Sispheor @UnderGreen @tomasfse