Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ecosystemincentive] Handle error case in more constructive and strict way #594

Open
taiki1frsh opened this issue Jun 8, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@taiki1frsh
Copy link
Collaborator

taiki1frsh commented Jun 8, 2023

In a method of Hooks, return err cannot be used. (technically it's possible,but it's just meaningless)

So, we emit panic.
But, emitting panic doesn't provide any information.
For better operation and explicit, make panic more helpful in a united form.

  • Provide the state info at the time of the panic
  • Provide the reason of the panic
  • (Possibly provide the solution for the panic)
  • Assure only this function goes back to the previous state
@taiki1frsh taiki1frsh added the enhancement New feature or request label Jun 8, 2023
@taiki1frsh taiki1frsh self-assigned this Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant