Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The project is lacking tests #28

Open
marcindulak opened this issue Feb 17, 2024 · 3 comments
Open

The project is lacking tests #28

marcindulak opened this issue Feb 17, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@marcindulak
Copy link
Contributor

marcindulak commented Feb 17, 2024 •
edited
Loading

  1. It may be an advantage to have some unit tests Implemented in 84dc8a3, more could be added.
  2. A larger advantage would be to preserve the functionality of the project by having a system for running regression tests against cases (md, asciidoc, etc) submitted by users
@marcindulak
Copy link
Contributor Author

Having tests could help to catch, or to verify cases like when issues are potentially closed without the feature being implemented in the expected way

#25
#26

@gaurav-nelson
Copy link
Contributor

gaurav-nelson commented May 5, 2024 •
edited
Loading

Thank you. Yup, I'm working on adding tests.

  • Added tests for image links and relative links

More to come.

@marcindulak
Copy link
Contributor Author

#26 still seems not working for me as expected with 9dc2d13

@gaurav-nelson gaurav-nelson added the enhancement New feature or request label May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
UmbrellaDocs/Linkspector
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcindulak @gaurav-nelson