Popup with showing new version, but this is the newest version

[supernevi]

Issue type: Bug report

Actual behaviour

On Windows 10 64bit with the current version:

Expected behaviour

Popup should not be shown currently and version number in left bottom corner should show the right version

Steps to reproduce

1. Go to https://github.com/UltraStar-Deluxe/Play/releases
2. Download StandaloneWindows64.zip
3. Start the game

the commit hash seems to be right

[achimmihca]

Whoops! How did the wrong version number end up in the Windows build?
Will take a look at it soon.

Are the other builds with correct version number?

[l3ztum]

@achimmihca linux build is also effected

[achimmihca]

The version was set already in January

Weird.

[achimmihca]

The new GitHub Actions build artifacts have the correct version number.
I don't know what went wrong in the release.

Will check this when creating the next release.

[achimmihca]

Indeed, the new builds have again the wrong version number. It shows 0.4.0 but VERSION.txt already has 0.5.0.

Furthermore, the git commit hash is missing now because of a Git security update that prevents running Git commands as before.
See

• https://stackoverflow.com/questions/71901632/fatal-unsafe-repository-home-repon-is-owned-by-someone-else
• Add git safe.directory game-ci/unity-builder#399

Guess I have to setup docker to debug this. Sucks...

[achimmihca]

I debugged the issue, not via docker, but via GitHub Actions and Debug.Log statements in a dedicated fork.

Looks like the Unity API returns an old value for Application.version and PlayerSettings.bundleVersion.
But the bundleVersion value in the file ProjectSettings/ProjectSettings.asset is correct.
No idea where Unity's C# API gets the old value from. I consider this a Unity bug.

Anyway, it works when fetching the value directly from the file instead of using Unity's API.

The commit hash can also be read from a file inside .git folder to avoid the issue with Git.

Will open a PR soon.