fix ackerror serialization/deserialization #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachary-rote
requested review from
jeffboutotte,
garyKeorkunian and
ckmcd
as code owners
| @@ -171,6 +175,18 @@ class PersistentActorSpec | |||
| } | |||
|
|
|||
| "PersistentActor" should { | |||
| "Serialize and Deserialize AckError" in { | |||
| val error = ACKError(new Exception("test-failure")) | |||
There was a problem hiding this comment.
You can test this through the Akka serializer as well (which is what actually gets used). We have a few of those in this suite actually. Looking a little closer it looks like maybe the compareStringResults bit from those might be hiding some issues with serialization
Codecov Report
@@ Coverage Diff @@
## main #270 +/- ##
==========================================
+ Coverage 59.92% 60.48% +0.55%
==========================================
Files 153 153
Lines 3244 3244
Branches 91 104 +13
==========================================
+ Hits 1944 1962 +18
+ Misses 1300 1282 -18
Continue to review full report at Codecov.
|
jeffboutotte
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.