I'm not sure why we're using VAO's when so much seems to be recreated each render, but this way at least the VAO itself wouldn't also be recreated even if the objects aren't.

Still TODO: Once the RenderBatch isn't recreated each time a slightly different render is made, VertexArrayObjects will actually be used, instead of just pretended to be used.
Also still TODO: any model will render as if the base color is matte dark grey. All the other rendering (like for 'lay-flat by face' or the blue model outline or the tool-arrows and such) and all the rendering _given that the cube is matte grey_ (like 'the error polka dot pattern' and the 'below the buildplate inversion') will still work properly. So everything works _except_ for the color and light-highlights. Why?

VAO includes shader uniforms, which where needed. So now, instead of cacheing per mesh alone, cache per mesh _per shader_. Currently the doesn't work 100% yet if different parts of a mesh are rendered with different settings, such as in the simulation view. Also need to check if the X-Ray view was supposed to be opaque or if that's another thing that doesn't work 100% yet (is usable though just not as pretty as remembered).

Instead of re-uploading the mesh each time the range changes, handle the range in the shaders with the new draw-range parameters.

Typing edition.

Co-authored-by: Jaime van Kessel <[email protected]>

Seems to have fixed the test as well. Not sure if it was ever a valid test if it can't create a VAO there.

Fixes type laziness, types should work harder!

Co-authored-by: Aldo Hoeben <[email protected]>

…anium into bremco-graphics_buffer_update

That's what it's for.

Contributes to issue CURA-8657.

Co-authored-by: Jaime van Kessel <[email protected]>

Contributes to issue CURA-8657.

Co-authored-by: Jaime van Kessel <[email protected]>

Spelling

Co-authored-by: Ghostkeeper <[email protected]>

(Our own) bindings aren't used like this, there's an 'updateBindings' for that, setUniformValue sets the 'unbound' (at least w.r.t. our _own_ system, not to be confused by the fact that u_drawRange is of course a bound value w.r.t. the 'raw' OpenGL/shader) value.

Not that it's likely to happen.