Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for creating new scanner with route array/string and not dictionary path #271

Open
3 of 14 tasks
someshkoli opened this issue Oct 23, 2020 · 1 comment
Open
3 of 14 tasks

Comments

@someshkoli
Copy link

someshkoli commented Oct 23, 2020

Context

Please select one:

  • I use the docker image ullaakut/cameradar
  • I use my own build of the docker image
  • I use the pre-compiled binary
  • I use my own build of the binary
  • None of the above / I don't know

Please select one:

  • I use a specific version:
  • I use the latest commit of the master branch
  • I use the latest commit of the develop branch
  • I use a forked version of the repository:
  • I use a specific commit:

Environment

My operating system:

  • Windows
  • OSX
  • Linux
  • Other

OS version: arch 5.8.11-arch1-1

Feature Request

The New method intakes onee functional parameter for using custom route path and credentials. I'm using this project as a library for my usecase. And picking routes / credentials from file is not so desirable for the usecase. Can we just add one method for each in which we can pass creds / routes in form of array and not filepath ? If yes then I would make a pr for same 🤔

Proposal

  • Method signature
    WithRoutes([]string) (*Scanner)
  • Usage
    cmrdr.WithRoutes([]string{"/route1", "/route2"})

Same with credentials. We will have to handle cases in which both/none/either of the two is provided.

@Ullaakut
Copy link
Owner

Good idea, makes sense :) Thanks for the suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants