Fix detection range setting #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, David. Thank you for your kindly help to test on MH-ZZ19 and fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I've tried to fix a problem with detection range setting on MH-Z19.
If you sent the original byte sequence for changing range to 0-2000ppm or 0-5000ppm to the sensor, range actually got set to 0-1000ppm. For some reason the bytes indicating the range have to be sent in an different order. I found out thaks to this analysis here: https://revspace.nl/MHZ19#Setting_the_measurement_range.
Also, we need someone to test it on MH-Z19B too, I have only tested this with MH-Z19.