-
-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Support for sortType and sortOrder in outputColumns #209
Comments
can u assign me with this issue |
Hello, I have a solution in my mind for outputColumns.sortOrder can you assign this issue to me? |
Hey @harshsennnn and @Anushlinux, If you don't get assigned don't worry there are other good first issues to look at, especially submitting your first sample via #40 Also you can join the discord server to discuss any queries with the community. |
Hello There this is how I would try to approach this issue : self.output_columns = sorted(
all_template_columns, key=custom_sort_output_columns
) According to the problem we have to modify and add parameters over the
We can try this approach for
If there is anything more to my approach that needs to be changed then please let me know |
Proposed Solution:
2.ALPHABETICAL: Sort the columns alphabetically.
Schema Changes: Update template_schema.py to reflect these new fields and validate the user inputs: 1.Ensure that sortType accepts only the allowed values (ALPHABETICAL, ALPHANUMERIC, CUSTOM). @Udayraj123 can I work on this ? |
@YashBaviskar1 that looks good. You can work on this feature. Meanwhile @Prasadayus I see you've commented on one more issue, you can work on that instead. |
Is your feature request related to a problem? Please describe.
Currently we support
outputColumns
to be custom defined and we sort in an ascending alphanumerical order by default.The users may want to dynamically sort the output columns in a descending order or just alphabetical instead of alphanumerical order.
Describe the solution you'd like
We sort the output columns here using the function custom_sort_output_columns.
outputColumns.sortType
(ALPHABETICAL, ALPHANUMERIC, CUSTOM) andoutputColumns.sortOrder
(ASC/DESC) in the template.jsonoutputColumns.columns
Describe alternatives you've considered
As of now user has to define the custom order in case of descending order. Which may not be possible in case of custom sets(v2)
Additional context
N/A
Note: please share your queries and approaches on discord for quicker discussions:
The text was updated successfully, but these errors were encountered: