Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insufficient funds error should propagate to user #119

Open
barbaraliau opened this issue May 11, 2021 · 0 comments
Open

Insufficient funds error should propagate to user #119

barbaraliau opened this issue May 11, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@barbaraliau
Copy link

Bug Description
If you don't have enough funds to pay for the transaction, the modal stays open and gives no indication that it failed. Dev tools console shows the following error:

Uncaught (in promise) Error: insufficient funds for intrinsic transaction cost (error={}, method="sendTransaction", transaction=undefined, code=INSUFFICIENT_FUNDS, version=providers/5.1.2)
    at e.value (index.ts:205)
    at e.value (index.ts:217)
    at A (json-rpc-provider.ts:49)
    at json-rpc-provider.ts:199

Steps to Reproduce

  1. Attempt to make a transaction with insufficient CELO

Expected Behavior
There should be some indication to the user of why this action failed. I initially just kept trying to do the transaction, reconnecting my Ledger, refreshing the page, etc. Related to #21 as implementing that feature would have prevented me from swapping too much CELO in the first place, though I still think it's important to propagate the error to the user in any case.

Additional Context
Context: On desktop using a Ledger
Version 1.23.71 Chromium: 90.0.4430.72 (Official Build) (x86_64)

@barbaraliau barbaraliau added the bug Something isn't working label May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant