Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sell collateral diff and Settle USDC balance after closing the short perp position #33

Open
acamill opened this issue Oct 26, 2021 · 2 comments
Open

Sell collateral diff and Settle USDC balance after closing the short perp position #33

acamill opened this issue Oct 26, 2021 · 2 comments
Assignees
@acamill
Labels
enhancement New feature or request
Milestone
Mango Devnet

Comments

@acamill
Copy link
Member

acamill commented Oct 26, 2021

The verification of "filled" quantity did not work...

Putting these here to remember. Will do today.

The settling need to be caller right before doing a new order seems.
Might be costy computing wise

Screenshot 2021-10-27 at 7 46 40 AM

Screenshot 2021-10-27 at 7 46 48 AM

Screenshot 2021-10-27 at 7 47 00 AM
@acamill acamill added the enhancement New feature or request label Oct 26, 2021
@acamill acamill added this to the Mango Integration milestone Oct 26, 2021
@acamill acamill self-assigned this Oct 26, 2021
@acamill
Copy link
Member Author

acamill commented Oct 27, 2021

More on settlement image

@acamill acamill changed the title Settle USDC balance before doing a new trade Settle USDC balance after closing the short perp position Oct 27, 2021
@acamill
Copy link
Member Author

acamill commented Nov 15, 2021

This should be done only if it's positive, else we just sell the remainder collateral and keep the usdc on the account

@acamill acamill changed the title Settle USDC balance after closing the short perp position Sell collateral diff and Settle USDC balance after closing the short perp position Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acamill acamill

Labels
enhancement New feature or request
Projects
None yet
Milestone
Mango Devnet
Development

No branches or pull requests
1 participant
@acamill