You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The code base seems to need some refactoring, which can be listed below:
Avoid using "Double Leading and Trailing Underscore" with the function and attribute names as they are reserved for Python language's special usage (e.g. __init__ is ok, but def __from_ds__ should better be renamed)
Comment/docstring to function name/task inconsistencies (e.g. def __from_ds__(self, dataset)) as well as comment/docstrings cleanup (the same function has both a comment and a docstring in almost same phrases)
Avoid wildcard imports as much as possible as they make it hard to know what actual code is being used from those imports (e.g. from .helpers import *)
The text was updated successfully, but these errors were encountered:
Avoid using "Double Leading and Trailing Underscore" with the function and attribute names as they are reserved for Python language's special usage (e.g. init is ok, but def from_ds should better be renamed)
Also mentioned in #88 (comment)
The code base seems to need some refactoring, which can be listed below:
__init__
is ok, butdef __from_ds__
should better be renamed)def __from_ds__(self, dataset)
) as well as comment/docstrings cleanup (the same function has both a comment and a docstring in almost same phrases)from .helpers import *
)The text was updated successfully, but these errors were encountered: