Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1D and 2D Least-squares Gaussian fit #94

Open
zeddie888 opened this issue Mar 8, 2023 · 2 comments
Open

1D and 2D Least-squares Gaussian fit #94

zeddie888 opened this issue Mar 8, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@zeddie888
Copy link
Collaborator

Test how good these are before trying Gaussian Grid

@zeddie888 zeddie888 added the enhancement New feature or request label Mar 8, 2023
@zeddie888 zeddie888 self-assigned this Mar 8, 2023
@zeddie888
Copy link
Collaborator Author

According to the Delabie paper:

  • The 2D least-squares Gaussian fit (with 9x9 window) has the best accuracy
  • Although Gaussian Grid is better than COG, it isn't better than 2D fit in terms of accuracy. In fact, it's accuracy is comparable to that of 1D fit

The hybrid Gaussian Grid (for determining better initial parameters) is probably the only thing worth implementing to speed up the least-squares fit methods

@markasoftware
Copy link
Member

markasoftware commented Mar 20, 2023

To test in ideal conditions:

  • Turn down the brightness so there aren't any "saturated" (full brightness) pixels.
  • Disable all generation noise (--generate-read-noise 0 and --generate-shot-noise fase)

Then the pixel brightnesses will actually be generated by a Gaussian function (

lost/src/io.cpp

Line 435 in ddccdfc

return generatedStar.peakBrightness * exp(-d0.MagnitudeSq() / (2*stddev*stddev));
), so there's no excuse for worse performance in that case. (It is possible that there's a bug in the generator meaning that the brightness distribution isn't actually Gaussian, but so far I've seen nothing to indicate that)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants