Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smarter pattern matching for Tetra #112

Open
zeddie888 opened this issue Apr 10, 2023 · 2 comments
Open

Smarter pattern matching for Tetra #112

zeddie888 opened this issue Apr 10, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@zeddie888
Copy link
Collaborator

From testing, it looks like Tetra is pretty susceptible to false positives (i.e. false stars).

Currently given a 4-star pattern, Tetra just returns immediately if it matches some catalog pattern. Also LOST's version of Tetra uses edge ratios for pattern construction, which is a simpler scheme but might be more prone to false positives?

Some ideas:

  • Look at how the original TETRA did pattern construction, I remember it being a lot more steps at least
  • Go through multiple 4-star combinations to find matches, accept the identification with smallest error
@zeddie888 zeddie888 added the enhancement New feature or request label Apr 10, 2023
@zeddie888 zeddie888 self-assigned this Apr 10, 2023
@markasoftware
Copy link
Member

Another simple improvement is to just not match if there are multiple matches all with low error, because there's no way to tell which one is right

@markasoftware
Copy link
Member

Another one is to check that the pattern didn't get flipped, which is called the spectrality check in pyramid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants