Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting the correct PYTHON_SITE_PACKAGES_PREFIX on Apple #988

Merged
merged 4 commits into from
Jan 29, 2015

Conversation

jbeezley
Copy link
Contributor

This will hopefully fix the latest Apple build failures.

@jbeezley jbeezley mentioned this pull request Jan 29, 2015
@aashish24
Copy link
Contributor

@jbeezley what version of Mac you tested this against?

@jbeezley
Copy link
Contributor Author

I have 10.10, but it also fixes the travis build. The problem it fixes should be independent of the OS version AFAIK.

@aashish24
Copy link
Contributor

Interesting. Are you using 10.10 SDK? Or is it finding the 10.9 SDK (check you cache file please). Iwill be curious.

@jbeezley
Copy link
Contributor Author

Well, both I guess.

$ grep SDK CMakeCache.txt 
CMAKE_OSX_SYSROOT:PATH=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk
CURL_INCLUDE_DIR:PATH=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/usr/include
LIBXML2_INCLUDE_DIR:PATH=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/usr/include/libxml2
LIBXSLT_INCLUDE_DIR:PATH=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/usr/include
READLINE_INCLUDE_DIR:PATH=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/usr/include/readline
UUID_INCLUDE_DIR:PATH=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/usr/include/uuid
ZLIB_INCLUDE_DIR:PATH=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/usr/include
FIND_PACKAGE_MESSAGE_DETAILS_LibXml2:INTERNAL=[/usr/lib/libxml2.dylib][/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/usr/include/libxml2][v2.9.0()]
FIND_PACKAGE_MESSAGE_DETAILS_LibXslt:INTERNAL=[/usr/lib/libxslt.dylib][/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/usr/include][v1.1.28()]
FIND_PACKAGE_MESSAGE_DETAILS_READLINE:INTERNAL=[/usr/lib/libreadline.dylib][/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/usr/include/readline][v()]
FIND_PACKAGE_MESSAGE_DETAILS_UUID:INTERNAL=[/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/usr/include/uuid][v()]
FIND_PACKAGE_MESSAGE_DETAILS_ZLIB:INTERNAL=[/usr/lib/libz.dylib][/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/usr/include][v1.2.5()]

@aashish24
Copy link
Contributor

Makes sense. We don't have a pure 10.10 build. Other than that it looks good.

jbeezley and others added 3 commits January 29, 2015 12:23
with system python branch from @2ashish24 things get installed somewhere else now on Mac
this catches it and fix error on json from vcs
doutriaux1 added a commit that referenced this pull request Jan 29, 2015
Setting the correct PYTHON_SITE_PACKAGES_PREFIX on Apple
@doutriaux1 doutriaux1 merged commit 265324f into master Jan 29, 2015
@doutriaux1 doutriaux1 deleted the fix-pythonpath-apple branch March 9, 2015 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants