Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vcs3D fix unexpected error 884 #886

Merged
merged 4 commits into from
Nov 13, 2014
Merged

Conversation

ThomasMaxwell
Copy link
Contributor

Fixes issue #884 and updates ctest images.

@doutriaux1
Copy link
Contributor

@ThomasMaxwell I get an error running ctest
286: Comparing 'dv3d_slider_test.png' to 'dv3d_slider_test.test.png'...diff=12.049673, New best!
286: All baselines failed! Lowest error (12.049673) exceeds threshold (10.000000).

I don't see visualy any difference and the diff picture seems blank... Not quite sure what to do about this.

@doutriaux1
Copy link
Contributor

picture my ctest generates:
dv3d_slider_test

@doutriaux1
Copy link
Contributor

picture I have for reference:
dv3d_slider_test test

@doutriaux1
Copy link
Contributor

and the official diff generated by ctest
dv3d_slider_test_diff

@doutriaux1
Copy link
Contributor

yep all black.... could be some transparency.... not sure...

doutriaux1 added a commit that referenced this pull request Nov 13, 2014
Vcs3D fix unexpected error 884

looks good passes all ctest now both on my mac and linux.
@doutriaux1 doutriaux1 merged commit 8e60550 into master Nov 13, 2014
@doutriaux1
Copy link
Contributor

@ThomasMaxwell please double check it works for you now ;)

@doutriaux1 doutriaux1 deleted the vcs3D-fix-unexpected-error-884 branch November 18, 2014 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants