-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Final commits to make buildbot pass #1316
Conversation
Well that didn't work... |
😢 how did you know? |
Build failed, but I reset it. I installed qt while the build was happening last time, so that could have broken something. |
Okay, should we go ahead and merge? |
Hold off for a bit. I'm going to see what is happening with vtk. |
Sounds good to me.... |
VTK build failed because the qt install messed up the GL setup. I can fix that, but the build failure wasn't reported by ctest and I'm not sure why:
|
what machine is this? |
garant.kitware.com. The GL library it picked up was an invalid symlink. The error above was in the |
Sounds like a system specific issue to me. |
Yes, the error is system specific, but it should have been reported as a build error to cdash. It wasn't: https://open.cdash.org/buildSummary.php?buildid=3809950 |
that is odd. Can you file a new issue for that? In the mean time I am merging this branch. |
Final commits to make buildbot pass
This has 2f508c3 cherry picked from
release
and 9a3e300 from #1314.