Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix list method #1287

Merged
merged 1 commit into from
May 6, 2015
Merged

Fix list method #1287

merged 1 commit into from
May 6, 2015

Conversation

ThomasMaxwell
Copy link
Contributor

Fixes #1285 .

@ThomasMaxwell ThomasMaxwell added this to the 2.2 milestone May 6, 2015
@doutriaux1
Copy link
Contributor

@ThomasMaxwell what about setting the default values to not None? Is that ok they are None?

@ThomasMaxwell
Copy link
Contributor Author

They are supposed to be None. Setting then to non-None overrides the default value.

From: Charles Doutriaux <[email protected]mailto:[email protected]>
Reply-To: UV-CDAT/uvcdat <[email protected]mailto:[email protected]>
Date: Wednesday, May 6, 2015 at 1:36 PM
To: UV-CDAT/uvcdat <[email protected]mailto:[email protected]>
Cc: "Maxwell, Thomas P. (GSFC-606.2)[SCIENCE APPLICATIONS INTL CORP]" <[email protected]mailto:[email protected]>
Subject: Re: [uvcdat] Fix list method (#1287)

@ThomasMaxwellhttps://github.com/ThomasMaxwell what about setting the default values to not None? Is that ok they are None?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1287#issuecomment-99546317.

@ThomasMaxwell
Copy link
Contributor Author

Vcs3D assumes that default values might be computed as a function of the input dataset (e.g. vertical scaling as a function of the number of levels in the dataset), therefore they are not hard coded in the graphics method. Anything specified in the graphics method overrides the default value.

From: , "Maxwell, Thomas P. (GSFC-606.2)[SCIENCE APPLICATIONS INTL CORP]" <[email protected]mailto:[email protected]>
Date: Wednesday, May 6, 2015 at 2:06 PM
To: UV-CDAT/uvcdat <[email protected]mailto:[email protected]>
Subject: Re: [uvcdat] Fix list method (#1287)

They are supposed to be None. Setting then to non-None overrides the default value.

From: Charles Doutriaux <[email protected]mailto:[email protected]>
Reply-To: UV-CDAT/uvcdat <[email protected]mailto:[email protected]>
Date: Wednesday, May 6, 2015 at 1:36 PM
To: UV-CDAT/uvcdat <[email protected]mailto:[email protected]>
Cc: "Maxwell, Thomas P. (GSFC-606.2)[SCIENCE APPLICATIONS INTL CORP]" <[email protected]mailto:[email protected]>
Subject: Re: [uvcdat] Fix list method (#1287)

@ThomasMaxwellhttps://github.com/ThomasMaxwell what about setting the default values to not None? Is that ok they are None?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1287#issuecomment-99546317.

@doutriaux1
Copy link
Contributor

makes sense. thanks.

doutriaux1 added a commit that referenced this pull request May 6, 2015
@doutriaux1
Merge pull request #1287 from UV-CDAT/vcs3D_fix_dv3d_list
94f63d6 
Fix list method
@doutriaux1 doutriaux1 merged commit 94f63d6 into release May 6, 2015
@doutriaux1 doutriaux1 deleted the vcs3D_fix_dv3d_list branch May 6, 2015 20:59
@aashish24 aashish24 mentioned this pull request May 22, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@doutriaux1 doutriaux1

Labels
DV3D
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@ThomasMaxwell @doutriaux1