Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PyOpenSSL to 0.14. #1253

Merged
merged 1 commit into from
May 14, 2015
Merged

Update PyOpenSSL to 0.14. #1253

merged 1 commit into from
May 14, 2015

Conversation

alliepiper
Copy link
Contributor

#1084 is popping up for me again on Arch Linux. This bumps PyOpenSSL to 0.14, which fixes the issue.

I'm targeting master for this, let me know if it should go into release instead/also.

@doutriaux1 @chaosphere2112 @aashish24

@aashish24
Copy link
Contributor

in theory, master should be good for new changes. I won't suggest it for release for now unless @doutriaux1 thinks otherwise.

@alliepiper
Copy link
Contributor Author

Can we get this merged soon? I have to cherry-pick it every time I pull a branch at the moment.

@aashish24
Copy link
Contributor

Since we already have a release branch. This can go in without further delay. @doutriaux1 can you do a quick test on it?

@dlonie since we have buildbot working now (not before), can you push a dummy commit on this branch so that we can trigger bulid again?

@remram44
Copy link
Contributor

I can't build this on my machine, I get weird C compiler errors... PYOPENSSL-install-err.log

@doutriaux1
Copy link
Contributor

@remram44 so this is a 10.10 machine right? but the logs seem to indicate it's picking up 10.9 SDK. Just for now, can you please try to move your 10.9 SDK directory so that it's not picked up?
@aashish24 we should really switch this all SDK logic so that it picks the SDK that matches your OS, not just the lower or greater one... I'll open an issue for this. @remram44 can you please tell me if moving the SDK fixes things for you for now. Thanks.

@alliepiper
Copy link
Contributor Author

I had issues building this when I had the setup_runtime.py sourced, since the pkg-config in the UVCDAT build won't detect the system libraries properly. Dunno if that's related, but it might be a similar issue.

@aashish24
Copy link
Contributor

@doutriaux1 that will be hard for reasons that a user can have multiple SDK's. I think my other branch addresses that. If you have 10.10 SDK, it will pick that first since we know that you installed that and therefore you moved on to the new version.

@doutriaux1
Copy link
Contributor

@aashish24 why is it hard?

uname -a
Darwin sofia.llnl.gov 14.3.0 Darwin Kernel Version 14.3.0: Mon Mar 23 11:59:05 PDT 2015; root:xnu-2782.20.48~5/RELEASE_X86_64 x86_64

From that we know we should be using 10.10, no?

@doutriaux1
Copy link
Contributor

10.9:

Darwin maryam 13.4.0 Darwin Kernel Version 13.4.0: Wed Mar 18 16:20:14 PDT 2015; root:xnu-2422.115.14~1/RELEASE_X86_64 x86_64

@aashish24
Copy link
Contributor

its hard because a user can have 10.9 or 10.10 SDK both at the same time. What I was saying is that we can fall back to the latest SDK in that case. What OS you are on is not so relevant. I think whats more relevant is what XCode version you have with what SDK.

@remram44
Copy link
Contributor

Looks like Python didn't build correctly with the 10.10 SDK out of the way

@doutriaux1
Copy link
Contributor

and 10.8

uname -a
Darwin sofia.llnl.gov 12.6.0 Darwin Kernel Version 12.6.0: Wed Dec 17 19:11:40 PST 2014; root:xnu-2050.48.15~1/RELEASE_X86_64 x86_64

@doutriaux1
Copy link
Contributor

@aashish24 I disagree, the BEST guess is to match OS version and SDK. Then if you can't match them go ahead and do what we do.

@doutriaux1
Copy link
Contributor

@remram44 so you're on 10.9? Ok, starting a build on 10.9 to see if I can reproduce as well.

@remram44
Copy link
Contributor

I'm on 10.10. This seems to be the issue, compiling with clang now.

@remram44
Copy link
Contributor

With clang, it works with the 10.9 SDK out of the way, but not if I don't move it, as you had suspected.

@doutriaux1
Copy link
Contributor

ok. @aashish24 I will submit a branch where we match SDK to user's OS by default. Too many people seem to run into this issue.

@doutriaux1
Copy link
Contributor

ok new PR at: #1320

aashish24 added a commit that referenced this pull request May 14, 2015
@aashish24 aashish24 merged commit 87b49e2 into master May 14, 2015
@aashish24 aashish24 deleted the pyopenssl-0.14 branch May 14, 2015 00:29
@aashish24 aashish24 mentioned this pull request May 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants