-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PyOpenSSL to 0.14. #1253
Conversation
in theory, master should be good for new changes. I won't suggest it for release for now unless @doutriaux1 thinks otherwise. |
Can we get this merged soon? I have to cherry-pick it every time I pull a branch at the moment. |
Since we already have a release branch. This can go in without further delay. @doutriaux1 can you do a quick test on it? @dlonie since we have buildbot working now (not before), can you push a dummy commit on this branch so that we can trigger bulid again? |
I can't build this on my machine, I get weird C compiler errors... PYOPENSSL-install-err.log |
@remram44 so this is a 10.10 machine right? but the logs seem to indicate it's picking up 10.9 SDK. Just for now, can you please try to move your 10.9 SDK directory so that it's not picked up? |
I had issues building this when I had the setup_runtime.py sourced, since the pkg-config in the UVCDAT build won't detect the system libraries properly. Dunno if that's related, but it might be a similar issue. |
@doutriaux1 that will be hard for reasons that a user can have multiple SDK's. I think my other branch addresses that. If you have 10.10 SDK, it will pick that first since we know that you installed that and therefore you moved on to the new version. |
@aashish24 why is it hard?
From that we know we should be using 10.10, no? |
10.9:
|
its hard because a user can have 10.9 or 10.10 SDK both at the same time. What I was saying is that we can fall back to the latest SDK in that case. What OS you are on is not so relevant. I think whats more relevant is what XCode version you have with what SDK. |
Looks like Python didn't build correctly with the 10.10 SDK out of the way |
and 10.8
|
@aashish24 I disagree, the BEST guess is to match OS version and SDK. Then if you can't match them go ahead and do what we do. |
@remram44 so you're on 10.9? Ok, starting a build on 10.9 to see if I can reproduce as well. |
I'm on 10.10. This seems to be the issue, compiling with clang now. |
With clang, it works with the 10.9 SDK out of the way, but not if I don't move it, as you had suspected. |
ok. @aashish24 I will submit a branch where we match SDK to user's OS by default. Too many people seem to run into this issue. |
ok new PR at: #1320 |
#1084 is popping up for me again on Arch Linux. This bumps PyOpenSSL to 0.14, which fixes the issue.
I'm targeting master for this, let me know if it should go into release instead/also.
@doutriaux1 @chaosphere2112 @aashish24