-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pressing the "i" key makes button disappear (and other issues) #1244
Merged
doutriaux1
merged 5 commits into
CDAT:release
from
chaosphere2112:deleting_text_makes_button_disappear
Apr 30, 2015
Merged
Pressing the "i" key makes button disappear (and other issues) #1244
doutriaux1
merged 5 commits into
CDAT:release
from
chaosphere2112:deleting_text_makes_button_disappear
Apr 30, 2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forgot to add the file? |
@doutriaux1 Nope, I typo'd. Should be blank_text. I'll update. |
@doutriaux1 Should be fixed now |
will have a look at it today.. |
doutriaux1
added a commit
that referenced
this pull request
Apr 30, 2015
…on_disappear Pressing the "i" key makes button disappear (and other issues)
ok tests pass for me, merging |
alliepiper
pushed a commit
that referenced
this pull request
May 28, 2015
Fixes #1244. This should eventually be expanded to the rest of vcs as the authors find time to update their code.
alliepiper
pushed a commit
that referenced
this pull request
May 28, 2015
Fixes #1244. This should eventually be expanded to the rest of vcs as the authors find time to update their code.
alliepiper
pushed a commit
that referenced
this pull request
Jun 15, 2015
Fixes #1244. This should eventually be expanded to the rest of vcs as the authors find time to update their code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 3 issues I found while testing text in the GUI; one was difficult to write a test for, so I punted on it, one was just a plain-out error, and the third is now properly tested.
del
'd bydetach
. This has been fixed.