Issue 1170 isofill mask

[doutriaux1]

No description provided.

[doutriaux1]

goes with CDAT/uvcdat-testdata#28
@chaosphere2112 @painter1 @aashish24 @dlonie please review

[alliepiper]

@doutriaux1 Several tests are failing on my machine with this:

The following tests FAILED:
        104 - vcs_test_basic_isofill_masked (Failed)
        160 - vcs_test_basic_isofill_masked_0_proj (Failed)
        170 - vcs_test_basic_isofill_masked_-3_proj (Failed)
        180 - vcs_test_basic_isofill_masked_aeqd_proj (Failed)
        268 - vcs_test_basic_isofill_bigvalues (Failed)
        279 - dv3d_vector_test (Failed)

https://www.cdash.org/viewTest.php?onlyfailed&buildid=3745021

The kicker is that, aside from the dv3d test, the baselines are actually invalid and the new images are correct. These tests should have been failing for quite a while.

Do we have any idea how many of the valid baselines we're testing against are actually correct? It might be worth having a vcs dev/user make a pass through them and make sure that we're really testing against valid baselines in UVCDAT -- otherwise we're just masking broken code that we should be aware of.

[aashish24]

This is interesting. I guess we are not checking / reviewing code thoroghly. The baselines indeed look wrong to me.

[alliepiper]

As for this patch, let's get it in once the additional baselines are added to the testdata patch.

[aashish24]

I agree @dlonie 👍

[doutriaux1]

@dlonie that's VERY interesting becausethe ctest actually passed for me yesterday (which was actually disturbing) which is why I added a test to make sure we catch this. I'm very glad it fails for you because it SHOULD fail. Would you mind updating the baselines then since you already have the good updated ones.

[alliepiper]

Sure. BTW, you can always grab the images off of a CDash failure page without regenerating them locally. They'll be identical to the ones produced during the test.

[alliepiper]

New baselines added. @doutriaux1 Can you retest on your machine and make sure these are working for you? If it passed for you yesterday it's worth seeing what happens with the current verisons -- feel free to merge this if everything looks good on your end.

[doutriaux1]

@dlonie I will retest with both old and new baseline. I "hope" I simply ran the ctest with a wrong version of uvcdat yesterday! But if not I will try to see why they pass whenthey shouldn't. Thanks for updating the baseline

[doutriaux1]

@dlonie ok good, these fail for me as well with old baseline! That's reassuring, testing against new baseline and merging in if it passes.

[doutriaux1]

yeo! we're good to go! merging in.