Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review RC [feature]: use automated tool for requirements #65

Closed
rcaneill opened this issue Apr 24, 2024 · 4 comments
Closed

Review RC [feature]: use automated tool for requirements #65

rcaneill opened this issue Apr 24, 2024 · 4 comments

Comments

@rcaneill
Copy link
Contributor

I see that they are no automated tool that handles the requirements for installing a clean dev environment. Options that I am aware of are:

  • poetry
  • anaconda / mamba
  • pipenv

I can help with poetry if you wish so. If you never heard of these tools, I can also explain a little more what they do. I believe that using one of these tools would also make #63 easier to handle.

@jbousquin
Copy link
Collaborator

The current dev installation should be working w/ conda/pipenv. Handling or requiring envs of a certain flavor is outside the scope of this package.

@rcaneill
Copy link
Contributor Author

rcaneill commented Jul 9, 2024

This will not be an issue for the review, but I’ll be happy if you could elaborate on why you don’t think that using an environment manager is out of scope? Using e.g. poetry would only imply minor changes to the pyproject file, with the benefit of having also an environment for developers that is locked and controlled, and so is reproducible. This can be helpful for users who want to rerun the tests in the same environment they were tested.

@jbousquin
Copy link
Collaborator

We've used conda and pyenv without issue (sometimes requires an extra line of code, e.g., without the environment.yml). If someone wants to use an additional env management tool power to them - but to add support for one means adding maintenance burden. The suggested approach is to run tests via github actions, avoiding 'it ran on my computer' issues with tests and taking burden off contributors.

@rcaneill
Copy link
Contributor Author

makes sense, thanks for answering

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants