Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for one sided AME as ensemble problem #97

Open
x94dai opened this issue Oct 16, 2022 · 1 comment
Open

Add support for one sided AME as ensemble problem #97

x94dai opened this issue Oct 16, 2022 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@x94dai
Copy link

x94dai commented Oct 16, 2022

It seems one just needs to add a build_ensembles_onesided_ame to the build_ensembles interface, which would look almost the same as the regular ame, replacing davies_from_interactions with onesided_ame_from_interactions. Not sure if there is concerns on the mathematical side.

@neversakura
Copy link
Collaborator

The reason why there is no onesided_ame ensemble problem is that the one-sided AME does not generate a CP map. The trajectory method currently implemented in HOQST does not work with this kind of ME. I am not sure if there are ways to unravel a non-CP ME. So a little bit more research is needed to find out if this is possible or not.

@neversakura neversakura added help wanted Extra attention is needed enhancement New feature or request labels Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants