Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor toa #40

Open
gvegayon opened this issue Oct 29, 2024 · 2 comments
Open

Refactor toa #40

gvegayon opened this issue Oct 29, 2024 · 2 comments
Assignees

Comments

@gvegayon
Copy link
Member

gvegayon commented Oct 29, 2024

The time of adoption vector toa currently allows information about a single adoption to be registered. We need to refactor this component so toa is computed as a function of the adoption/cumadop matrices (arrays). You need to:

  • Remove references to toa in the code and replace it with toa_mat() or something similar.
  • The toa_mat() or something similar function should compute times of adoption based on the adopt matrix.

Some functions where $toa is present:

  • diffnet.attrs
  • toa_diff
  • diffnet.toa
  • diffnet.toa<-
  • diffnet.subset.slices
  • summary.diffnet
  • ...

Look for calls to $toa or diffnet.toa(.

@gvegayon
Copy link
Member Author

Hey @twvalente! Here is the space to start discussing how to approach the problem.

@aoliveram
Copy link
Collaborator

Currently, toa is a matrix (for multi-diffusion) with one column for each behavior. When a single diffusion is run, the output is the same as before, so there is no need to replace $toa with something like a function for the moment. Let me know if that is enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants