-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add playwright qa scenarios #480
Conversation
✅ Deploy Preview for ghg-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for adding these, @stephenkilbourn, looks great! This gives us a good foundation that will make it easy to build upon and add more scenarios.
I noticed the scenarios are currently commented out in the .github workflow. Are there any blockers to enable them again in this PR before merging it? Like that we could already test the whole pipeline with the next GHG Center version bump.
Also, what are your thoughts on migrating some of these scenarios to the veda-ui
repo? We have mocked data there used for development and theoretically we could already run the tests earlier as part of the UI release process before they reach the instances.
I had disabled the workflow during the last GHG deploy because running yarn start was taking over 3 minutes to start the server and delaying a passing build. I'll re-enable it here and look into some caching to see if there's a way to improve that. It would also be my preference to run tests if possible in the UI. catching issues as early as possible makes debugging easier. I'll look into if I see a clear way to delineate without duplicating code. |
@slesaad - I see the test failed because the Hub link in the header has |
@stephenkilbourn thanks so much for updating the tests! so quick too! 🥳 |
_The PR name should be the version to be deployed (ex: v1.0.1)_ - [x] Bump the version in the package.json or equivalent. --- - # Changelog - ## 🎉 Features - 🦗 - ## 🚀 Improvements - Update veda-ui to [v5.8.0](https://github.com/NASA-IMPACT/veda-ui/releases/tag/v5.8.0) - Add new event and announcement to "News & Events" #613 - Add playwright QA scenarios #480 - ## 📊 Dataset Updates - Rescale values changed for `gra2pes-ghg-monthgrid-v1` #616 - Minor Content changes #615 #613 - ## 📝 Stories Updates - Update embedded custom interface for urban dashboard and NIST interface US-GHG-Center/custom-interfaces#119 - ## 🐛 Fixes - Fix text and video over lap when zoomed in #618
This addresses test scenarios mentioned in NASA-IMPACT/veda-ui#1024
The playwright suite will be able to run through the following scenarios relying on the test data already in the
/datasets
and/stories
directories which expands to 66 unique tests on the GHG dev branch:"look as expected" was vague, so for now it is testing that no javascript errors appear that would break the page. Other assertions could be made.
I've attached the html of a test run report to illustrate what a successful run would look like.
index.html.zip