-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add static typecheck system to poetry #114
Conversation
730c5ea
to
2d1427a
Compare
once more, this time with feeling... |
Do we want to use |
I'm in favour of standardising and using the |
I intend to get this PR merged as-is. The changes so far allow use of My intention is to require that pyright types all new modules from here on out, including the proposed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take everything I say with a pinch of salt, as I'm still learning good coding practices. Here are my 2 cents.
Overall, very happy to see some typechecks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems mostly fine, it appears that your poetry.lock
needs to be updated though
This PR intentionally updates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me. Still have a lock file warning in the checks though. Action log link
From one wide-ranging-dev-changes pull request to the next - now we have code style, I'm starting work on issue #56.
First step: get mypy to not throw errors on the current code, then I'll add a GH workflow for it for future branches. I've based this off the #111 PR branch, because I don't want to bother typing the entire
channels
cog when it's about to be removed.