-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update workflow and deps #111
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM conditional on the #94 changes being rebased in.
I assume this'll fix all our deprecation warnings? I can't see anything that touches save-state
or set-output
, unless they're pulled in via the deps you've updated.
dc2aa2e
to
0a57b14
Compare
Yeah all those seemingly were part of the outdated deps, which is very convenient |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm still. you've reminded me to do a wider documentation review at some point, cause rn it's all pretty shit
We use an automated code formatter called [Black](https://black.readthedocs.io/), currently this needs to be run manually to pass the format CI check. To run Black, run from the root of the repo: | ||
|
||
```bash | ||
poetry run black uqcsbot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does that work? poetry just inherently knows which files to do? massive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well in this case, its running it on the folder uqcsbot so it's smart enough to know what files to run it on otherwise
I've also now gone and:
|
Updating workflow dependencies, and also package dependencies as well.
While I was here, I removed the channel cog and dealt with some quick deprecation warnings (ie SQLAlchemy 2)
Closes #105
Update 10th May I've also now gone and: