fix(company-house): company house API response #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… empty body for 404
… empty body for 404
AlexBramhill
approved these changes
Jul 30, 2024
abhi-markan
changed the title
abhi-markan
changed the title
avaitonis
reviewed
Jul 31, 2024
src/helper-modules/companies-house/wrap-companies-house-http-error-callback.ts
Show resolved
Hide resolved
src/helper-modules/companies-house/wrap-companies-house-http-error-callback.ts
Outdated
Show resolved
Hide resolved
src/helper-modules/companies-house/wrap-companies-house-http-error-callback.ts
Outdated
Show resolved
Hide resolved
AlexBramhill
approved these changes
Jul 31, 2024
|
abhi-markan
added a commit
that referenced
this pull request
Jul 31, 2024
🤖 I have created a release *beep* *boop* --- ## [1.21.4](v1.21.3...v1.21.4) (2024-07-31) ### Bug Fixes * **company-house:** company house API response ([#967](#967)) ([c9234b8](c9234b8)) * **deps:** update dependency mssql to v11 ([#954](#954)) ([8942563](8942563)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction ✏️
Company house no longer returns expected body (below) for a non-existent company with an 8 digit CRN.
{ "errors": [ { "type": "ch:service", "error": "company-profile-not-found" } ] }Resolution ✔️
404response.createWrapCompaniesHouseHttpGetErrorCallback.Miscellaneous ➕