generated from UK-Export-Finance/nestjs-template
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(DTFS-7049): added POST /emails endpoint for sending emails using GOV.UK Notify service #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xternal-gov-notify-api
…xternal-gov-notify-api
avaitonis
changed the title
WIP feat(DTFS-7049): added POST /emails endpoint for sending emails using GOV.UK Notify service
feat(DTFS-7049): added POST /emails endpoint for sending emails using GOV.UK Notify service
May 14, 2024
avaitonis
force-pushed
the
feat/DTFS2-7049/new-external-gov-notify-api
branch
from
May 31, 2024 12:33
8f2f357
to
41d314c
Compare
avaitonis
force-pushed
the
feat/DTFS2-7049/new-external-gov-notify-api
branch
from
May 31, 2024 12:37
41d314c
to
c14fa49
Compare
Thanks Co-authored-by: oscar-richardson-softwire <[email protected]>
…xternal-gov-notify-api
…/github.com/UK-Export-Finance/mdm-api into feat/DTFS2-7049/new-external-gov-notify-api
oscar-richardson-softwire
previously approved these changes
May 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, LGTM :)
…xternal-gov-notify-api
Quality Gate passedIssues Measures |
oscar-richardson-softwire
approved these changes
May 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
abhi-markan
added a commit
that referenced
this pull request
Jun 4, 2024
🤖 I have created a release *beep* *boop* --- ## [1.21.0](v1.20.0...v1.21.0) (2024-06-04) ### Features * **DTFS-7049:** added POST /emails endpoint for sending emails using GOV.UK Notify service ([#820](#820)) ([3a1bf0e](3a1bf0e)) * **DTFS2-7049:** fixed tests caused by removal of global transformer and allowing extra params ([71e44ff](71e44ff)) * **DTFS2-7049:** fixing PR issues ([e0e099e](e0e099e)) * **DTFS2-7049:** removed BadRequestException tests moving payload to object instead of array ([3bb8d71](3bb8d71)) * **DTFS2-7049:** return error message as string instead of array ([86b5b4d](86b5b4d)) * **DTFS2-7049:** test unknown Gov.UK Notify responses ([c14fa49](c14fa49)) * **DTFS2-7121:** create Companies House endpoint ([#821](#821)) ([7860528](7860528)) ### Bug Fixes * **eslint:** reverted back to eslint `8.57.0` ([#905](#905)) ([75ca97c](75ca97c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction ✏️
We are moving GOV.UK Notify integration from DTFS to MDM API.
Resolution ✔️
govuk-notify
notifications-node-client
to communicate with GOV.UK Notifyemails
with endpoint POST /emailsNotifyClient
for each request. This is because each request can have different GOV.UK Notify API key.Request example:
Auth headers:
Body:
Response example:
New packages
notifications-node-client
- GOV.UK Notify packageNew Environment variables
Miscellaneous ➕
withStringFieldValidationApiTests
fromtfs-api
projectwithEmailFieldValidationApiTests
withObjectFieldValidationApiTests
tfs-api
projectforbidNonWhitelisted: true, transformOptions: { enableImplicitConversion: true, },
from global ValidationPipe. It was creating auto transformations after moving to single object payload.