Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error in light card button documentation #1529

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DavidSchischke
Copy link

Additional information

  • This PR fixes or closes issue: N/A
  • This PR is related to issue: N(A
  • Link to documentation pull request:

Checklist

  • [ x] The code change is tested and works locally.
  • [ x] There is no commented out code in this PR.
  • [ x] I have followed the contribution guidelines
    • [x ] This PR is for a custom-card or documentation change and therefore directed to the main branch.
    • This PR is for a official card or any other directly to the integration related change and therefore directed to the release branch.

@DavidSchischke
Copy link
Author

Hi there, I just spent 20 minutes figuring out why my "ulm_card_light_brightness_med" configuration would not work and always default to 50%. Looking at the Template code, it is clear that this should be medium instead of med, which is only displayed wrongly in the documentation.

grafik grafik

I fixed this in the table and touched nothing else in the hopes of saving others a few minutes of headaches., Sorry if this is not up to your quality standards, I'm not a seasoned Open Source contributor (yet). Cheers!

@DavidSchischke
Copy link
Author

Also, it looks like something with the pipelines is off. Local pre-commit hooks ran without errors, the Code Quality tests here fail due to some card I have not touched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant