Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location Prompt Bug #1178

Closed
5 tasks done
a6wu opened this issue Jan 13, 2021 · 10 comments
Closed
5 tasks done

Location Prompt Bug #1178

a6wu opened this issue Jan 13, 2021 · 10 comments
Labels
Bug Something isn't working

Comments

@a6wu
Copy link
Contributor

a6wu commented Jan 13, 2021

Time Tracking: MA-34

From a user:

I discovered a bug in the mobile app. When I open the app it asks if I want to turn on my Location for a better experience. When I say No, it pops up again for a total of 5 times before the app crashes. My device is an Android – Moto Z Play Droid.

This is done when:

  • Shuttle location provider refactored
  • Wayfinding location provider refactored
  • FutureBuilder used inside Wayfinding StreamBuilder for local permission availability (@asg003)
  • PR 1405 Test Plan PASS on iOS
  • PR 1405 Test Plan PASS on Android
@a6wu a6wu added the Bug Something isn't working label Jan 13, 2021
@g9singh
Copy link
Contributor

g9singh commented Jan 15, 2021

Tried to reproduce on my nexus 5 using the following builds:
7.2.15 PROD
7.2.14 Prod
DEV build from experimental branch

Was unable to reproduce on any of the listed builds.
The device is running android version 6.0.1.

@a6wu
Copy link
Contributor Author

a6wu commented Jan 15, 2021

@g9singh Is there Moto Z Play Droid device on one of the device farms?

@gmihir
Copy link
Contributor

gmihir commented Jan 15, 2021

Could not reproduce on Samsung Galaxy S6 on experimental or current production version from the Play Store. Currently running Android 8.0.0

@g9singh
Copy link
Contributor

g9singh commented Jan 19, 2021

@a6wu I just ran it on device farm.

I couldn't find Moto Z in the device list so I tried similar devices. Unfortunately they do not reproduce the bug.

@g9singh
Copy link
Contributor

g9singh commented Jan 22, 2021

From my initial research we have 4 options for other device farm like services:

@c3bryant do you have any suggestions/preferences based on the CI/CD setup we have?

@anaaamika
Copy link
Contributor

Reproduced on Samsung S7 running Android 8.0.0 using build 7.6.0 QA and 7.5.0 QA. App crashes in both instances whether accepting or declining to turn on device location.

Screenshot_20210218-151712_Google Play services

@g9singh
Copy link
Contributor

g9singh commented Feb 22, 2021

Upon further investigation, it seems that the app is requesting permissions again from the wayfinding feature. We already have a LocationDataProvider that handles the permissions and returns a stream of coordinates. Please use that instead of a creating a new instance of the Location object.

Once the wayfinding feature is refactored to use the LocationDataProvider the permissions issue should be resolved.

@anaaamika
Copy link
Contributor

Shuttle feature also creates another instance of the Location object and needs to be refactored to use stream from LocationDataProvider.

@kevdesilva01
Copy link
Contributor

Test passed but Scans are being logged in the wrong folder in S3. I opened a new issue after speaking with Alex regarding this. #1422

@c3bryant c3bryant self-assigned this Jun 14, 2021
@c3bryant c3bryant added the Failed Testing Issue failed testing label Jun 14, 2021
@kevdesilva01 kevdesilva01 self-assigned this Jun 21, 2021
@c3bryant c3bryant added 7.9 and removed Failed Testing Issue failed testing labels Jun 21, 2021
@c3bryant
Copy link
Contributor

Data logs going to the wrong folder has been resolved.

@c3bryant c3bryant closed this as completed Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

7 participants