Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Events Card Mockup #1107

Closed
13 tasks done
a6wu opened this issue Nov 18, 2020 · 3 comments
Closed
13 tasks done

Implement Events Card Mockup #1107

a6wu opened this issue Nov 18, 2020 · 3 comments

Comments

@a6wu
Copy link
Contributor

a6wu commented Nov 18, 2020

ITS-Pro time category: https://its-pro.ucsd.edu/browse/MA-113

This is done when:

  • Limit event list title to 2 lines (1)
  • Remove event list up arrow (2)
  • Fix event list vertical spacing (Android) (3)

Notes:

Previously Completed Tasks:

  • Events card redesign integrated to campus mobile
  • If event has no image, then use student placeholder image
  • Event detail text renders (both light mode and dark mode) on physical device
  • Event tile widget file reimplementation (to fix the alignment and container size issue, try to avoid magic numbers)
  • Clip thumbnail images to one shape such that the width fits the container
  • Dark mode theme is supported
  • New placeholder image for the event tile widget (no white border)
  • Resolve rendering issue for detail view seen on TestFlight
@c3bryant c3bryant changed the title Implement News Card Mockup Implement Events Card Mockup May 27, 2021
@sramcode sramcode self-assigned this Sep 9, 2021
@xxwwyytt1 xxwwyytt1 self-assigned this Sep 10, 2021
@c3bryant c3bryant assigned c3bryant and unassigned sramcode, xxwwyytt1 and c3bryant Oct 28, 2021
@gmihir gmihir self-assigned this Nov 3, 2021
@kevdesilva01 kevdesilva01 self-assigned this Nov 4, 2021
@gmihir gmihir added Failed Testing Issue failed testing and removed In Testing labels Nov 10, 2021
@gmihir
Copy link
Contributor

gmihir commented Nov 10, 2021

Failed on iOS, saw a lot of the same issues Kevin reported on Android.

@p8gonzal
Copy link
Contributor

p8gonzal commented Mar 7, 2022

iOS and Android testing complete from me. Provided notes in both spreadsheets. Android build may not be a pass. Formatting issue, requires further investigation.

@p8gonzal p8gonzal removed their assignment Mar 7, 2022
@kevdesilva01
Copy link
Contributor

Same results as peter, they functioned properly, but I noticed some formatting errors on Android. There are some design choices that might need to be followed up on (the arrow on each tile and the spacing between each card)

@kevdesilva01 kevdesilva01 added the Failed Testing Issue failed testing label Mar 7, 2022
@kevdesilva01 kevdesilva01 removed their assignment Mar 7, 2022
@c3bryant c3bryant assigned c3bryant and unassigned sramcode and xxwwyytt1 Mar 28, 2022
@c3bryant c3bryant added In Testing 7.19 and removed Failed Testing Issue failed testing In Testing labels Mar 28, 2022
@c3bryant c3bryant removed their assignment Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

7 participants