Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github LTI authentification does not use primary github email #1004

Open
AlexandreDoneux opened this issue May 28, 2024 · 0 comments
Open

Github LTI authentification does not use primary github email #1004

AlexandreDoneux opened this issue May 28, 2024 · 0 comments

Comments

@AlexandreDoneux
Copy link
Contributor

AlexandreDoneux commented May 28, 2024

Describe the bug
When using GitHub to sign up the email address was set to one of my non-primary email addresses. It seems like it is using the oldest email address added to my GitHub account.

After suppressing the unwanted email addresses and trying again, this time the complete name was not pre-completed and the email address was one of an already existing user in DB. This may be caused by a lookup in DB with an empty username (complete name).

INGInious installation details

  • Version: v.0.9.dev211+gb3a40952

To Reproduce
Steps to reproduce the behavior:

  1. Have a GitHub account with multiple email addresses and the first one not being the primary address.
  2. Click on 'sign in'.
  3. Select the GitHub logo below 'Sign in with'
  4. See error

Expected behavior
Display the correct complete name and the primary GitHub email address.

Screenshots

Screenshot from 2024-05-28 11-26-39

@AlexandreDoneux AlexandreDoneux added Bug Triage needed Project maintainers still have to review this issue labels May 28, 2024
@anthonygego anthonygego added Priority: Critical and removed Triage needed Project maintainers still have to review this issue labels May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants