Milestone 4 Feedback

[negsadr]

Congratulations on finishing milestone 4! We can see you put a lot of work into this project, nice work!
Below we list some specific feedback you can use to improve your project.
We provide tick boxes for you to use in the future as you address these concerns to improve the final grade of your project.
If anything is unclear, please feel free to ask questions in this issue thread.

---

1. GitHub actions workflow for continuous integration

rubric={mechanics:35}

Well done!

2. Documentation

rubric={reasoning:25}

Well done!

3. License checklist

rubric={reasoning:10}

Well done!

4. Initiate a package review request

rubric={mechanics:10}

• The Python package review has not been opened and/or it is not using the template - -5 mechanics
• The R package review has not been opened and/or it is not using the template - -5 mechanics

5. Specific expectations for this milestone

rubric={mechanics:10}

Well done!

6. Submission instructions

rubric={mechanics:10}

Well done!

[eyrexh]

Hi Negar @negsadr ,

Thank you for the feedback.
I have opened the issues for peer reviewing in the repo and other classmates have even finished the reviewing last week. I do not get it why the marks have been deducted. Please check the below link.
Python: UBC-MDS/software-review-2023#20
R: UBC-MDS/software-review-2023#14

If you mean the links have not been provided in the Milestone 4 submission, I checked the submission requirements again and it does not mention the peer review issue links.

Regards,
Eyre

[negsadr]

Hi @eyrexh
Thanks for noting that! I'm modifying your grade!
good luck!

[eyrexh]

Thank you!