Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial feedback on the refactored frontend #42

Open
6 of 10 tasks
aarppe opened this issue Mar 23, 2023 · 5 comments
Open
6 of 10 tasks

Initial feedback on the refactored frontend #42

aarppe opened this issue Mar 23, 2023 · 5 comments
Labels
bug Something isn't working improvement

Comments

@aarppe
Copy link

aarppe commented Mar 23, 2023

Things to consider and improve:

  1. Headings
    • (center-justify the headings)
    • left-justify the linguistic word-content, i.e. the Cree words in the non-row/column-header cells
    • in panes, separate components of multipart heading with – (n-dash: –) or pipe (|, e.g. Prs+Ind -> present tense | independent or something is happening now | ni-/ki- word (BACKEND)
  2. Column/row heading
    • left-justify the non-heading row and column labels
  3. Cell content
    • show multiple word-forms for any cell vertically stacked
    • left-justify the non-heading row and column labels
    • indicate the source of the audio with emojis, with human emoji for human-pronounced audio, and robot-head emoji for synthesized audio (BACKEND)
    • indicate word-forms that have been observed in a corpus in bold-face (as previously). (BACKEND)
  4. General Settings / Other
    • In the drop-down settings, separate the orthography options from the labelings options with a horizontal (hair)line
    • explore if the font in the paradigms could be more similar/slender, as in the production version
@aarppe aarppe added bug Something isn't working improvement labels Mar 23, 2023
@aarppe
Copy link
Author

aarppe commented Mar 24, 2023

@Eluviian @nienna73 Here's a list of lesser issues with the refactored frontend that would benefit from attention.

@nienna73
Copy link
Contributor

nienna73 commented Apr 4, 2023

Of the tasks above, the following are actually backend tasks and should be moved to the backend repo:

  • Separate components of multipart headings with a dash or a pipe.
    The relabelling happens on the backend, so only the backend knows about the individual parts. As such, only the backend can add the divider

  • Indicate the source of the audio with emojis
    As of right now, the backend only looks for the recording URL. It will need to add/return the speaker as well as the recording URL in order to implement this. The backend should decide on the emoji, not the frontend. The backend should look at the recording speaker, see if it's SDOL (I believe that's "Synthesized Dolores"), and add a new field called "recording_emoji" with the correct value based on the speaker value. The frontend should only have to display the emoji.

  • Indicate wordforms that have been observed in the corpus
    I'm not actually too sure how this is happening right now, so whoever implements this will have to look at the original/legacy morphodict code so find the logic. Once again, this will need to be added to the paradigm as a new field in the JSON called "observed" with a value of "true" or "false" (or something like that). Once the backend does this, the frontend will decide on styles based on the value of "observed". The backend portion needs to be done first, though.

@nienna73 nienna73 closed this as completed Apr 4, 2023
@nienna73
Copy link
Contributor

nienna73 commented Apr 4, 2023

The wording of left-justify the linguistic word-content needs clarification. What is "linguistic word-content"? Which page is this on? Where is this information located? One or multiple screenshots would be helpful.

@nienna73 nienna73 reopened this Apr 4, 2023
@nienna73
Copy link
Contributor

nienna73 commented Apr 4, 2023

I didn't mean to close the issue, I had a keyboard/mouse disagreement that posted my earlier comment before I was ready. This issue should have never been closed.

@aarppe
Copy link
Author

aarppe commented Apr 4, 2023

The wording of left-justify the linguistic word-content needs clarification. What is "linguistic word-content"? Which page is this on? Where is this information located? One or multiple screenshots would be helpful.

Doing this like the current production version (which left-justifies everything except the pane headings), which we could generally adhere to:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working improvement
Projects
None yet
Development

No branches or pull requests

2 participants