Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round the corners of all boxes #2

Open
nienna73 opened this issue Dec 22, 2022 · 3 comments
Open

Round the corners of all boxes #2

nienna73 opened this issue Dec 22, 2022 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@nienna73
Copy link
Contributor

In the search results and home pages, the content boxes should have slightly rounded corners as they currently do in production. This should be achieved through a combination of CSS and React properties.

How it current looks:
Screen Shot 2022-12-22 at 1 36 22 PM

How it should look:
Screen Shot 2022-12-22 at 1 36 46 PM

The difference is subtle but important.

@nienna73 nienna73 added enhancement New feature or request good first issue Good for newcomers labels Dec 22, 2022
@nyedr
Copy link

nyedr commented Dec 22, 2022

Hi, I'm interested in taking on this issue. Could you please clarify the task for me? I just want to make sure I understand everything correctly: should I only focus on rounding the corners of the content boxes and home pages? Also, could you provide me with the class names and/or file names for the content boxes and home pages that need to be changed? If it's all content boxes, then just the home page names would be enough. Thank you in advance for your help.

@nienna73
Copy link
Contributor Author

Hi @EidanGar, sorry for the mix up, I actually flagged this as a good first issue for a new intern we have starting in the new year. I really appreciate your interest, though!

@nyedr
Copy link

nyedr commented Dec 22, 2022

@nienna73 no problem at all! Thank you for letting me know about the mix up. I understand that the intern will be taking on this issue, and I wish them the best of luck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants