Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add Tab support like in Terminal Tabs. #4

Open
gerane opened this issue Mar 14, 2017 · 4 comments
Open

Feature Request: Add Tab support like in Terminal Tabs. #4

gerane opened this issue Mar 14, 2017 · 4 comments

Comments

@gerane
Copy link

gerane commented Mar 14, 2017

I almost think these two extensions would work well if merged together. It would be nice if terminals opened via Shell Launcher would show up as Tabs in the Terminal Tabs extension

@Tyriar
Copy link
Owner

Tyriar commented Mar 14, 2017

Interesting idea, I prefer to be as modular as possible with my extensions but I was thinking it might make sense to merge some of the functionality into a terminal power tools extension or something.

I'm curious how you're finding terminal tabs, I switched it off shortly after developing the extension as I thought it would be better to deal with the raw commands typically. The fact that all terminals may not show up is also a pain (the limitation in https://marketplace.visualstudio.com/items?itemName=Tyriar.terminal-tabs).

@WencesLlobet
Copy link

Is there any keyboard shorcut to switch between shells? I haven't found it in the docs of your git. That would be a nice step, maybe tabs are not fully needed if we can navigate through shortcuts.
Thanks for the extension by the way!

@Tyriar
Copy link
Owner

Tyriar commented Oct 28, 2017

@LauLlobet since the terminal was created fairly late all the keybindings that made sense were already taken so there is no shortcut to switch between terminals. This is what I use in my keybindings.json:

{ "key": "ctrl+shift+j",    "command": "workbench.action.terminal.focusNext" },
{ "key": "ctrl+shift+k",    "command": "workbench.action.terminal.focusPrevious" },

@WencesLlobet
Copy link

Thanks Tyriar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants