Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open to override user's terminal.integrated.shell.<platform> when a shell is launched #37

Open
SheepDomination opened this issue Apr 10, 2019 · 9 comments

Comments

@SheepDomination
Copy link

I want to know why shell launcher does not override "terminal.integrated.shell.windows": in the settings.json file ? When switching from, lets say; Bash to command (DOS) the termainal changes to DOS but if I run a python file in the terminal, instead of the terminal remaining in DOS, it switches to Bash ?

@Tyriar
Copy link
Owner

Tyriar commented Apr 11, 2019

That's just how I designed it; a separate command that uses its own config and doesn't mess with the regular settings.

@Tyriar Tyriar closed this as completed Apr 11, 2019
@SheepDomination
Copy link
Author

Could you possibly make an option so that it can override the "terminal.integrated.shell.windows": ?

@Tyriar
Copy link
Owner

Tyriar commented Apr 12, 2019

Sure, open for PRs. I guess it would go just here to set the setting when the extension setting is set:

const terminal = vscode.window.createTerminal(terminalOptions);

@Tyriar Tyriar reopened this Apr 12, 2019
@Tyriar Tyriar changed the title Shell Launcher does not override: integrated.shell.windows in settings.json Open to override user's terminal.integrated.shell.<platform> when a shell is launched Apr 12, 2019
@SheepDomination
Copy link
Author

SheepDomination commented Apr 12, 2019

@Tyriar What do you mean by PRs ?

@Tyriar
Copy link
Owner

Tyriar commented Apr 12, 2019

@SheepDomination
Copy link
Author

@Tyriar What is the latest version of VSCode Shell Launcher, I'm currently using version 0.2.0 and there is not src folder that contains extension.ts and Code extension updater does not find a recent version of Shell Launcher ?

@Tyriar
Copy link
Owner

Tyriar commented Apr 12, 2019

The extension doesn't ship the src/ folder, you would need to clone this repository and make changes there. https://github.com/Tyriar/vscode-shell-launcher/tree/master/src

@SheepDomination
Copy link
Author

@Tyriar From what I understand of git it sounds as if the extension searched for the extension.ts file when in use and would read this data from the git ?

@Tyriar
Copy link
Owner

Tyriar commented Apr 12, 2019

I suggest reading up on git, how to contribute to github via pull requests and vscode extension development if you want to tackle this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants