From 618bdf3293296a44d10a1a03e13dc987f477a708 Mon Sep 17 00:00:00 2001 From: Konrad Garus Date: Fri, 1 Sep 2017 01:05:25 +0100 Subject: [PATCH 1/2] chore(docs): Add header for "usage" in router-store readme (#337) --- docs/router-store/README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/router-store/README.md b/docs/router-store/README.md index 6bb08e2239..a3907c2366 100644 --- a/docs/router-store/README.md +++ b/docs/router-store/README.md @@ -12,6 +12,8 @@ Install @ngrx/router-store from npm: `npm install github:ngrx/router-store-builds` OR `yarn add github:ngrx/router-store-builds` +## Usage + During the navigation, before any guards or resolvers run, the router will dispatch a ROUTER_NAVIGATION action, which has the following signature: ```ts From 870a73d9e7f08dca72cf61fd15fdee7958c66dfb Mon Sep 17 00:00:00 2001 From: Brandon Date: Thu, 31 Aug 2017 21:20:26 -0500 Subject: [PATCH 2/2] chore(docs): Fix import for EffectNotification (#339) --- docs/effects/api.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/effects/api.md b/docs/effects/api.md index 1f618cb581..3e8c9f12cd 100644 --- a/docs/effects/api.md +++ b/docs/effects/api.md @@ -107,7 +107,7 @@ import 'rxjs/add/operator/takeUntil'; import { Injectable } from '@angular/core'; import { Observable } from 'rxjs/Observable'; import { Action } from '@ngrx/store'; -import { Actions, Effect, OnRunEffects, EffectsNotification } from '@ngrx/effects'; +import { Actions, Effect, OnRunEffects, EffectNotification } from '@ngrx/effects'; @Injectable() export class UserEffects implements OnRunEffects { @@ -119,7 +119,7 @@ export class UserEffects implements OnRunEffects { console.log(action); }); - ngrxOnRunEffects(resolvedEffects$: Observable) { + ngrxOnRunEffects(resolvedEffects$: Observable) { return this.actions$.ofType('LOGGED_IN') .exhaustMap(() => resolvedEffects$.takeUntil('LOGGED_OUT')); }