Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(union): ensure union type with null or unknown will mock the first type #322

Merged
merged 1 commit into from
May 13, 2020
Merged

fix(union): ensure union type with null or unknown will mock the first type #322

merged 1 commit into from
May 13, 2020

Conversation

uittorio
Copy link
Member

No description provided.

@uittorio uittorio requested a review from Pmyl May 13, 2020 16:41
@Pmyl
Copy link
Collaborator

Pmyl commented May 13, 2020

This is a breaking change, do we want to have a new major version for this?

Pmyl
Pmyl approved these changes May 13, 2020
View reviewed changes
Copy link
Collaborator

@Pmyl Pmyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering about major versioning this

@uittorio uittorio merged commit a2d58ad into master May 13, 2020
@uittorio uittorio deleted the fix/union-with-null-and-unknown branch May 31, 2020 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pmyl Pmyl Pmyl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uittorio @Pmyl