-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(map): add Map support as a type #228
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also changed a linting rule for indentation, remove some code regarding typescript types, fixed a bug when using typeof variable without type and function call initializer and removed descriptor 'case' for function call
uittorio
reviewed
Feb 8, 2020
Pmyl
changed the title
#225 add Map support as a type
feat(map): add Map support as a type
Feb 8, 2020
uittorio
reviewed
Feb 8, 2020
uittorio
reviewed
Feb 8, 2020
uittorio
reviewed
Feb 8, 2020
uittorio
reviewed
Feb 8, 2020
@@ -62,5 +58,10 @@ export function GetType(node: ts.Node, scope: Scope): ts.Node { | |||
return GetType(node.type, scope); | |||
} | |||
|
|||
if (ts.isCallExpression(node)) { | |||
const declaration: ts.Declaration = TypescriptHelper.GetDeclarationFromNode(node.expression); | |||
return GetType(GetReturnNodeFromBody(declaration as ts.FunctionDeclaration), scope); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may want to add some test for when is not a function declaration .
a = test()
}
const test = () => {
return 'ss'
}```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no casting anymore, the change is quite big actually
uittorio
reviewed
Feb 8, 2020
uittorio
approved these changes
Feb 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also changed a linting rule for indentation, remove some code regarding typescript types, fixed a bug when using typeof variable without type and function call initializer and removed descriptor 'case' for function call