Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(definitelyTyped): add node types in generated tsconfig #186

Merged
merged 1 commit into from
Jan 16, 2020
Merged

fix(definitelyTyped): add node types in generated tsconfig #186

merged 1 commit into from
Jan 16, 2020

Conversation

Pmyl
Copy link
Collaborator

@Pmyl Pmyl commented Jan 16, 2020

Currently types like gen-readlines fails with the message:

error TS2591: Cannot find name 'Buffer'.
Do you need to install type definitions for node?
Try `npm i @types/node` and then add `node` to the types field in your tsconfig.

With this PR I'm adding 'node' in the list of types to fix it.

@Pmyl Pmyl requested a review from uittorio January 16, 2020 17:04
@Pmyl Pmyl merged commit 19caa94 into master Jan 16, 2020
@uittorio uittorio deleted the fix_types_requiring_node branch January 29, 2020 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uittorio uittorio uittorio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pmyl @uittorio