perf(emit): decrease emitted code #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d by not always using get/set for properties
uittorio
reviewed
Jan 14, 2020
| @@ -4,6 +4,8 @@ import { KeyCounter } from './keyCounter'; | |||
| export type PossibleDeclaration = ts.InterfaceDeclaration | ts.ClassDeclaration | ts.TypeAliasDeclaration; | |||
|
|
|||
| export class FactoryUniqueName { | |||
| private static AnonymousIdentifierText: string = '*'; | |||
There was a problem hiding this comment.
Can we put these values with the other one? Do you think it's a good idea to keep all these "reduced" identifier names in one place?
…e mockProperty file so that it reflects its new purpose
|
@uittorio I've also renamed mockProperty.ts to reflect the new purpose |
uittorio
approved these changes
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR decreate emitted code by using minification techniques and by not always using get/set for properties. The emitted code is reduced in average by 35%.
Use case is mocking the entire
@types/babel-typesmodule:Current version
626583 characters
ADD assign properties by always using element access (
m["prop"] = 0)447669 characters
ADD reduced string identifier for factory (
create__NAME__mockto@NAME)434162 characters
ADD element access only when signature is there, otherwise object literal (
m = { "prop": 0 })428726 characters
ADD
undefined -> void 0and don't assignvoid 0properties408600
ADD
false -> !1andtrue -> !0404922
I've also found that by reducing Repository/Merge/Extension import variable name and methods name to 1-2 characters we could even drop that number to 35k~ but I think that needs more investigation.