Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search results can't be clicked #534

Closed
jonchardy opened this issue Jun 16, 2017 · 2 comments
Closed

Search results can't be clicked #534

jonchardy opened this issue Jun 16, 2017 · 2 comments

Comments

@jonchardy
Copy link
Contributor

jonchardy commented Jun 16, 2017

This actually happens to be a theme issue, but I figure it will get more attention here.

When using the search feature, it's possible to navigate between results and hit enter and be taken to that page. Also, on mobile devices, it's possible to touch a result and be taken to that page. Clicking a result, however, doesn't take the user to the page, which is a big problem.

I imagine this is some sort of issue with jQuery intercepting the click event before the anchor can be processed, but my knowledge in that realm is limited. Does anyone know how to fix this?

EDIT: Even more interesting, a normal-speed click doesn't work, but if the mouseup occurs the instant after mousedown (click very quickly), it correctly navigates to the search result.

The file that handles this is https://github.com/TypeStrong/typedoc-default-themes/blob/master/src/default/assets/js/src/typedoc/components/Search.ts.

@millsp
Copy link

millsp commented Jul 31, 2019

@aciccarello
Copy link
Collaborator

I believe this should be fixed on the latest version of typedoc-default-themes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants