Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

our caching for readDirectory drops all but the first argument #962

Closed
cspotcode opened this issue Feb 16, 2020 · 1 comment · Fixed by #969
Closed

our caching for readDirectory drops all but the first argument #962

cspotcode opened this issue Feb 16, 2020 · 1 comment · Fixed by #969

Comments

@cspotcode
Copy link
Collaborator

ts.sys.readDirectory accepts a half-dozen arguments, but our caching wrapper drops all but the first. It seems like this isn't causing bugs because typescript normally doesn't call this function. Perhaps it's only used to populate the files array based on tsconfig "include" and "exclude" arrays, so our implementation is never called.

It looks like a bug waiting to happen, unless I'm missing something. We can either drop the caching or write a different wrapper that puts all arguments into the cache key.

1e838f7

@cspotcode cspotcode changed the title our caching for readDirectory drops all but the first argument. our caching for readDirectory drops all but the first argument Feb 16, 2020
@blakeembrey
Copy link
Member

Sounds reasonable to drop the caching here 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants