You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ts.sys.readDirectory accepts a half-dozen arguments, but our caching wrapper drops all but the first. It seems like this isn't causing bugs because typescript normally doesn't call this function. Perhaps it's only used to populate the files array based on tsconfig "include" and "exclude" arrays, so our implementation is never called.
It looks like a bug waiting to happen, unless I'm missing something. We can either drop the caching or write a different wrapper that puts all arguments into the cache key.
The text was updated successfully, but these errors were encountered:
cspotcode
changed the title
our caching for readDirectory drops all but the first argument.
our caching for readDirectory drops all but the first argument
Feb 16, 2020
ts.sys.readDirectory
accepts a half-dozen arguments, but our caching wrapper drops all but the first. It seems like this isn't causing bugs because typescript normally doesn't call this function. Perhaps it's only used to populate the files array based on tsconfig "include" and "exclude" arrays, so our implementation is never called.It looks like a bug waiting to happen, unless I'm missing something. We can either drop the caching or write a different wrapper that puts all arguments into the cache key.
1e838f7
The text was updated successfully, but these errors were encountered: