Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning if files is omitted from tsconfig.json #57

Closed
jbrantly opened this issue Sep 25, 2015 · 5 comments
Closed

Add warning if files is omitted from tsconfig.json #57

jbrantly opened this issue Sep 25, 2015 · 5 comments

Comments

@jbrantly
Copy link
Member

All files in the directory and subdirectory are included if files is omitted from tsconfig.json. This typically results in some errors of some sort as all kinds of crap can get added (TypeScript lib files, for instance). I think it might be useful to detect this condition and just print a simple warning.

@OldrichDlouhy
Copy link

In TypeScript 1.6 there is an option to exclude directories when you do not specify the files property - see microsoft/TypeScript#3043. So if this is implemented it needs to take the exclude property into acount.

@jbrantly
Copy link
Member Author

jbrantly commented Oct 6, 2015

Good point. FWIW, exclude does already work in ts-loader, but you're definitely right that any warning message would need to take that into account.

@stale
Copy link

stale bot commented Jan 19, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

1 similar comment
@stale
Copy link

stale bot commented Mar 20, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 20, 2019
@stale
Copy link

stale bot commented Mar 27, 2019

Closing as stale. Please reopen if you'd like to work on this further.

@stale stale bot closed this as completed Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants