Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use resolveSync on loader when available #423

Closed
johnnyreilly opened this issue Dec 20, 2016 · 1 comment
Closed

Use resolveSync on loader when available #423

johnnyreilly opened this issue Dec 20, 2016 · 1 comment

Comments

@johnnyreilly
Copy link
Member

Having boldly upgraded to enhanced-resolve v3 this seems to be causing issues for some people.

Given that webpack 2 comes with a resolveSync available on the loader it may make sense to roll back to the previous approach where we used enhanced-resolve v0.9 and in servicesHost.ts try to use the resolveSync (which will work for webpack 2) and fallback to the 0.9 one (for webpack 1).

In the longer term we'd then look to remove the dependency on enhanced-resolve entirely when webpack 2 is RTM'd. Hopefully this should resolve the following issues:

#421 #420 #417

@johnnyreilly
Copy link
Member Author

Hmmm... This does not appear to be a go-er. The underlying resolver in webpack is not initialised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant